Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecations #7579

Merged
merged 1 commit into from
May 23, 2020
Merged

Update deprecations #7579

merged 1 commit into from
May 23, 2020

Conversation

MikeMcQuaid
Copy link
Member

@MikeMcQuaid MikeMcQuaid commented May 15, 2020

Add more deprecations, disable deprecations and remove disabled code.

Do not merge this until the next Homebrew/brew tag will be a minor version (2.3).

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew tests with your changes locally?

@Bo98
Copy link
Member

Bo98 commented May 16, 2020

will be a minor version (2.4).

No 2.3?

@Bo98 Bo98 mentioned this pull request May 16, 2020
6 tasks
@MikeMcQuaid
Copy link
Member Author

No 2.3?

Fixed. I cannot remember these things apparently any more 😅

Add more deprecations, disable deprecations and remove disabled code.
@MikeMcQuaid MikeMcQuaid merged commit e1f3c8d into Homebrew:master May 23, 2020
@MikeMcQuaid MikeMcQuaid deleted the deprecations branch May 23, 2020 13:38
@BrewTestBot BrewTestBot added the outdated PR was locked due to age label Dec 29, 2020
@Homebrew Homebrew locked as resolved and limited conversation to collaborators Dec 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants